Test for Unique Capture Group Parsing #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 91.31% 91.31%
=======================================
Files 17 17
Lines 2441 2441
=======================================
Hits 2229 2229
Misses 212 212 ☔ View full report in Codecov by Sentry. |
cpisciotta
added a commit
that referenced
this pull request
Feb 10, 2025
As a prerequisite to #365, delete this overly-generic definition that conflicts with `ShellCommandCaptureGroup`. Given there aren't tests against this regular expression, it's unclear what output it actually expects and how it differs from `LinkerDuplicateSymbolsCaptureGroup`. Given this definition is formatted as `nil` output, we can safely delete this type; deleting this type won't impact user-facing logs, so the only known trade-off is a potential time regression.
cpisciotta
force-pushed
the
charles/ParsingTestsCount
branch
2 times, most recently
from
4adf8c9 to
5c9f304
Compare
cpisciotta
changed the title
cpisciotta
force-pushed
the
charles/ParsingTestsCount
branch
7 times, most recently
from
d9aa979 to
ba8d1b0
Compare
cpisciotta
added a commit
that referenced
this pull request
Feb 11, 2025
## Changes Prerequisite to #365. Prevents conflicts with `NonPCHClangCommandCaptureGroup`.
cpisciotta
force-pushed
the
charles/ParsingTestsCount
branch
from
ba8d1b0 to
5df61bd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a unit test that checks if each line of xcodebuild output is captured by at most 1 type.