-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[format.string.std] Replace "Derived Extracted Property" with simply "property" #6224
Conversation
@cor3ntin , @tahonermann , any opinions on the above? The rationale sounds plausible. |
Unicode says
I think the change make sense but maybe we should do something similar for http://eel.is/c++draft/lex.name#1 |
I agree that the change is reasonable; the context is sufficient for readers to discover details about the property as desired. I also agree with Corentin's suggestion to replace similar wording elsewhere. |
@cor3ntin , what do you want to change in http://eel.is/c++draft/lex.name#1 ? The "Derived Core Properties" mention is in an note, explaining XID_Start and XID_Continue. That seems reasonably explanatory to me. |
Maybe something like Ie the fact that they are derived is not really adding any information |
@cpplearner Could you please have another look? |
I agree that the mention of "Derived Core Properties" is unneeded. But it's slightly different from the case with East_Asian_Width, which is not a derived property, and it's wrong to describe it as such. |
@cpplearner, can you elaborate on that concern? Unless I'm missing something, the proposed change simply refers to @tkoeppe, can you also make the change that @cor3ntin suggested? |
@tahonermann Do you mean as a separate, unrelated change? |
@tkoeppe, preferably as part of this change since it is somewhat related. |
@tahonermann Ah, OK, but it's not my pull request :-) We'll have to ask @cpplearner. |
I'm unable to make the change due to network issues, and since this PR has "allow edits by maintainers" checked, maintainers can push to my branch as they wish :) |
I finally managed to commit the change. Ping |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
LGTM |
Ship it! |
rebased. ping @tkoeppe |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's do that.
"Derived Extracted Property" refers to the fact that the data for the
East_Asian_Width
property are extracted into the fileDerivedEastAsianWidth.txt
. It is not really a terminology.