-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't define typedef-names in the library wording #6419
base: main
Are you sure you want to change the base?
Don't define typedef-names in the library wording #6419
Conversation
46aa0dc
to
ed407e0
Compare
ed407e0
to
dd1a092
Compare
This comment was marked as resolved.
This comment was marked as resolved.
I'm very much on board with replacing "defined" with "declared" when we're talking about the introduction of a name, such as "X is declared if and only if..." I think that's a straightforward fix and actually improves the presentation quite a bit. For situations where we describe what the "value" of a typedef is, I like "defined" a bit better, because it's alluding to the mathematical idea of "definition", and that's what we do in those contexts. A better way of phrasing this without using the term "defined" might exist, but "determined" leaves open a bit who determines what. Maybe "specified to be" would work; I'm not sure. Anyway, if you want to extract the changes of the first category into a separate pull request, where we actually talk about the (presence of) a typedef declaration, then that could probably progress faster. |
dd1a092
to
9bab345
Compare
@jensmaurer Now the changes to "determined" are reverted. |
9bab345
to
ddd5f43
Compare
ddd5f43
to
0e8ef31
Compare
Also mention [re].
In the example, it seems a bit verbose to say "declarations and definitions".
Use "declare" instead.
Use "declare" instead.
Use declared" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
Use "declare" instead.
0e8ef31
to
6fb7a92
Compare
Rebased & force-pushed. @tkoeppe @jensmaurer |
Since (non-template) typedef-names are declared but not defined ([basic.def]/2.9, [basic.def]/2.10).
value_type
(or sometimestype
?) is not always a typedef-name, but it is in most case. So, I'm changing to use "declared" for it.iterator_category
anditerator_concept
, this PR used to use "determined" instead of "defined" when the aliased type is talked. Now the changes to "determined" are reverted.