Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't define typedef-names in the library wording #6419

Open
wants to merge 27 commits into
base: main
Choose a base branch
from

Conversation

frederick-vs-ja
Copy link
Contributor

@frederick-vs-ja frederick-vs-ja commented Jul 26, 2023

Since (non-template) typedef-names are declared but not defined ([basic.def]/2.9, [basic.def]/2.10).

  • In [library], I think sometime it would be better to use "shown" or "specified".
  • The member type value_type (or sometimes type?) is not always a typedef-name, but it is in most case. So, I'm changing to use "declared" for it.
  • For member types iterator_category and iterator_concept, this PR used to use "determined" instead of "defined" when the aliased type is talked. Now the changes to "determined" are reverted.

@frederick-vs-ja frederick-vs-ja force-pushed the declare-typedef-names branch 2 times, most recently from 46aa0dc to ed407e0 Compare August 2, 2023 16:46
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Apr 19, 2024
@frederick-vs-ja

This comment was marked as resolved.

@jensmaurer jensmaurer removed the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Apr 23, 2024
@jensmaurer
Copy link
Member

jensmaurer commented Apr 23, 2024

I'm very much on board with replacing "defined" with "declared" when we're talking about the introduction of a name, such as "X is declared if and only if..." I think that's a straightforward fix and actually improves the presentation quite a bit.

For situations where we describe what the "value" of a typedef is, I like "defined" a bit better, because it's alluding to the mathematical idea of "definition", and that's what we do in those contexts. A better way of phrasing this without using the term "defined" might exist, but "determined" leaves open a bit who determines what. Maybe "specified to be" would work; I'm not sure.

Anyway, if you want to extract the changes of the first category into a separate pull request, where we actually talk about the (presence of) a typedef declaration, then that could probably progress faster.

@frederick-vs-ja
Copy link
Contributor Author

@jensmaurer Now the changes to "determined" are reverted.

source/lib-intro.tex Outdated Show resolved Hide resolved
@wg21bot wg21bot added the needs rebase The pull request needs a git rebase to resolve merge conflicts. label Oct 16, 2024
@frederick-vs-ja
Copy link
Contributor Author

Rebased & force-pushed. @tkoeppe @jensmaurer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs rebase The pull request needs a git rebase to resolve merge conflicts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants