[dcl.init.string] Shorten example string #6489
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eisenwave
force-pushed
the
shorten-example-string
branch
from
1cd9048
to
87fb9da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firstly, this edit shortens the string literal used in the example. This is necessary because the original author makes a point about why
sizeof(msg) == 25. Due to the length of the old literal, it is not possible to estimate its length at first glance. Most readers cannot tell by intuition that"Syntax error on line %s\n"is 25 characters long, and might even make a mistake while counting. The new"Hi\n"literal has a length which serves the example much better.Secondly, this edit adds a comma before at
is a single character, and becausebecause it is grammatically more appropriate.