-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[depr] Reorder clauses by origin of deprecation #7294
Conversation
ef7904c
to
a58709b
Compare
Rebased, updated for the creation of the new [text] clause, and force-pushed. |
Thanks! |
source/future.tex
Outdated
@@ -1,4 +1,4 @@ | |||
%!TEX root = std.tex | |||
nnn%!TEX root = std.tex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's nnn
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A keyboard gone rogue. Force-pushed the fix.
a58709b
to
11dcf4d
Compare
source/future.tex
Outdated
\rSec2[depr.format.syn]{Header \tcode{<format>} synopsis} | ||
|
||
\pnum | ||
The header \libheaderref{format}{format.syn} has the following additions: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reference was broken, I fixed it at head.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I have corrected this now, and force-pushed again.
Reorders the deprecated features annex to follow the order of the main clauses that the deprecates feature refers to. Where multiple clauses are references, use the one named by the [depr.XXX] stable label.
11dcf4d
to
216d3c3
Compare
Due to papers targeting Annex D, this PR will go stale quickly! Could we flag it with either a C++26 or a C++29 milestone so that I can appropriately prioritize keeping it up to date? |
Is this just moving text around without any changes? We can take this now, but I'm not sure this is generally worthwhile tracking. |
Yes, this is entirely a copy/paste re-ordering of the clause. When features are deprecated they try to insert themselves at the appropriate location in this clause, but over time that ordering becomes stale. One it is correctly ordered it is easy for subsequent additions to preserve the ordering, until the next Great Clause Renumbering. |
It's not just great renumberings, also any smaller moves would potentially need to check if they're linked to any deprecations. I'm OK with occasional cleanup, though, I don't think we need to overengineer this. |
Reorders the deprecated features annex to follow the order of the main clauses that the deprecates feature refers to. Where multiple clauses are references, use the one named by the [depr.XXX] stable label.