Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[depr] Reorder clauses by origin of deprecation #7294

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

AlisdairM
Copy link
Contributor

Reorders the deprecated features annex to follow the order of the main clauses that the deprecates feature refers to. Where multiple clauses are references, use the one named by the [depr.XXX] stable label.

@AlisdairM
Copy link
Contributor Author

Rebased, updated for the creation of the new [text] clause, and force-pushed.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 16, 2024

Thanks!

@@ -1,4 +1,4 @@
%!TEX root = std.tex
nnn%!TEX root = std.tex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's nnn?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A keyboard gone rogue. Force-pushed the fix.

\rSec2[depr.format.syn]{Header \tcode{<format>} synopsis}

\pnum
The header \libheaderref{format}{format.syn} has the following additions:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reference was broken, I fixed it at head.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I have corrected this now, and force-pushed again.

Reorders the deprecated features annex to follow the order
of the main clauses that the deprecates feature refers to.
Where multiple clauses are references, use the one named by
the [depr.XXX] stable label.
@AlisdairM
Copy link
Contributor Author

Due to papers targeting Annex D, this PR will go stale quickly!

Could we flag it with either a C++26 or a C++29 milestone so that I can appropriately prioritize keeping it up to date?

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 17, 2024

Is this just moving text around without any changes? We can take this now, but I'm not sure this is generally worthwhile tracking.

@AlisdairM
Copy link
Contributor Author

Yes, this is entirely a copy/paste re-ordering of the clause.

When features are deprecated they try to insert themselves at the appropriate location in this clause, but over time that ordering becomes stale. One it is correctly ordered it is easy for subsequent additions to preserve the ordering, until the next Great Clause Renumbering.

@tkoeppe
Copy link
Contributor

tkoeppe commented Oct 17, 2024

It's not just great renumberings, also any smaller moves would potentially need to check if they're linked to any deprecations. I'm OK with occasional cleanup, though, I don't think we need to overengineer this.

@tkoeppe tkoeppe merged commit 7f7170c into cplusplus:main Oct 17, 2024
2 checks passed
@AlisdairM AlisdairM deleted the sort_annex_D_by_clause branch October 17, 2024 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants