Rename non-type template parameter/argument to "constant" #7587
+72
−74
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As previously discussed by CWG. The aim is to editorially adopt some of the wording changes made in P2841R5 to ease its review in core. Note that not all-instance of non-type have been mechanically replaced as [dcl] and [diff] use the term to refer to anything that is not a type in the context of lookup
jensmaurer
requested changes
Jan 26, 2025
jensmaurer
reviewed
Jan 26, 2025
hubert-reinterpretcast
suggested changes
Feb 2, 2025
|
@jensmaurer Can we make progress on this this week? I am afraid things are going to be rather messy otherwise. Thanks |
hubert-reinterpretcast
approved these changes
Feb 4, 2025
|
@tkoeppe , I'd like to merge this ASAP. |
|
All squashed as one commit? |
|
Right after #7485 if that's OK? |
|
Yes, that needs to be squashed and the commit-message needs to get at least the label [std] or so. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As previously discussed by CWG.
The aim is to editorially adopt some of the wording changes made in P2841R5 to ease its review in core.
Note that not all-instance of non-type have been
mechanically replaced as [dcl] and [diff] use
the term to refer to anything that is not a type
in the context of lookup