Development #2
Open
Development #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_DeltaFlex into development
Create cmake.yml
…_DeltaFlex into development
…_DeltaFlex into development
…_DeltaFlex into development
…_DeltaFlex into development
a-badin
approved these changes
May 20, 2023
|
|
||
| TEST(EvolutionTest, test_selectionCountOne) | ||
| { | ||
| DFWorldScene *sc = new DFWorldScene(); |
There was a problem hiding this comment.
утечка памяти, создавайте на стеке или через unique_ptr
| DFWorldScene *sc = new DFWorldScene(); | ||
| std::vector<Model*> stickmans; | ||
|
|
||
| for (int i = 0; i < 1; i++) |
| for (int i = 0; i < 1; i++) | ||
| { | ||
| DFEntity &stickman = sc->addNewObject("stickman_" + std::to_string(i)); | ||
| stickman.addComponent(new StickmanPhysicsComponent()); |
| evo.Selection(); | ||
| evo.getBestCount(); | ||
|
|
||
| EXPECT_EQ(evo.getBestCount(), 7); |
There was a problem hiding this comment.
Не совсем понятно почему 7 но ладно, не помешал бы комментарий
| Link l(pm1, pm2, 10, 10, true); | ||
|
|
||
| auto oldLen = pm1.m_pos - pm2.m_pos; | ||
| float dist = oldLen.length(); |
There was a problem hiding this comment.
ожидаемое значение должно вычисляться гарантировано работающим правильно кодом, еще лучше не вычислять его а просто захардкодить. В противном случае вы тестируете вашу логику против вашей логики
|
|
||
| std::array<float, 11> res = {-0.103591, 0.604108, -0.986522, -0.997239, 0.971981, -0.5389, 0.903677, 0.916517, -0.162188, 0.974992, -0.864615}; | ||
|
|
||
| for (int i = 0; i < 11; i++) |
a-badin
approved these changes
May 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
engine and tests