Frame and tests for the database #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- checkUserByEmail(const std::string &email) -> bool - checkUserByUsername(const std::string &username) -> bool
a-badin
approved these changes
May 20, 2023
| BidsTable(std::shared_ptr<IDatabase> client); | ||
|
|
||
| json addBid(const json &info) const; | ||
| json deleteBid(const size_t id) const; |
There was a problem hiding this comment.
в объявлении обычно const у value не пишут
| class IDatabase | ||
| { | ||
| public: | ||
| virtual json createTable(json) = 0; |
There was a problem hiding this comment.
кажется немного странно конвернтировать из представления базы данных в json, чтобы потом json cконвертировать уже в классы вашей бизнес логики. возможно было бы лучше возвращать тут std::string
| return data; | ||
| } | ||
|
|
||
| static inline std::shared_ptr<PostgreSQL> client; |
There was a problem hiding this comment.
Не нужно делать static объекты - глобальные состояния это всегда плохо (если они не const). Gtest специально для каждого теста создает новый экземпляр BaseTestConnection, чтобы он не мог быть в каком-то промежуточном состоянии от предыдущих тестов. Через static вы эту логику меняете, так, что теперь любой тест, который сломает client или connection может сломать все тесты сразу
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.