Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add -Wextra -Werror to b2 builds #49

Merged
merged 14 commits into from
Jan 10, 2024
Merged

Add -Wextra -Werror to b2 builds #49

merged 14 commits into from
Jan 10, 2024

Conversation

cmazakas
Copy link
Collaborator

@cmazakas cmazakas commented Jan 5, 2024

Update our b2 CI to be fully clean under -Wextra -Werror for all toolchains.

@codecov Codecov
Copy link

codecov bot commented Jan 5, 2024 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (6507175) 88.05% compared to head (29c915b) 85.11%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop      #49      +/-   ##
===========================================
- Coverage    88.05%   85.11%   -2.94%     
===========================================
  Files          200       77     -123     
  Lines        11599     4200    -7399     
===========================================
- Hits         10213     3575    -6638     
+ Misses        1386      625     -761
Files Coverage Δ
include/boost/http_proto/detail/header.hpp 100.00% <ø> (ø)
include/boost/http_proto/detail/impl/workspace.hpp 97.87% <ø> (ø)
include/boost/http_proto/fields_base.hpp 100.00% <ø> (ø)
include/boost/http_proto/fields_view_base.hpp 100.00% <ø> (ø)
include/boost/http_proto/rfc/detail/rules.hpp 100.00% <ø> (ø)
src/detail/header.cpp 94.01% <100.00%> (ø)
src/fields_base.cpp 93.09% <100.00%> (+0.01%) ⬆️
src/fields_view_base.cpp 95.89% <100.00%> (+0.08%) ⬆️
src/file_posix.cpp 83.44% <100.00%> (ø)
src/message_base.cpp 85.34% <100.00%> (ø)
... and 4 more

... and 123 files with indirect coverage changes

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6507175...29c915b. Read the comment docs.

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

1 similar comment
@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

1 similar comment
@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cmazakas cmazakas force-pushed the feature/werror branch 2 times, most recently from 3172549 to 054b531 Compare January 10, 2024 19:35
@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

1 similar comment
@cppalliance-bot
Copy link

GCOVR code coverage report https://49.http-proto.prtest.cppalliance.org/gcovr/index.html
LCOV code coverage report https://49.http-proto.prtest.cppalliance.org/genhtml/index.html
Coverage Diff https://49.http-proto.prtest.cppalliance.org/gcovr/coverage_diff.txt

@cmazakas cmazakas merged commit 42cb4d5 into cppalliance:develop Jan 10, 2024
50 of 51 checks passed
@cmazakas cmazakas deleted the feature/werror branch January 10, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cmazakas @cppalliance-bot