Fix type of "definitions" attribute #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the specified type of the "definitions" attribute to reflect that null values are allowed (as specified in the prose). Improve type parsing to be more robust about how union types are split. Add support for 'nullable' types. Currently, we don't really support prose generation for compound types where the inner value is a union type. (Schema generation doesn't have this limitation and can handle these just fine.) The 'nullable' type is a bit of a hack for this specific instance, but for now it's good enough for the types that actually exist in the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the specified type of the "definitions" attribute to reflect that null values are allowed (as specified in the prose). Improve type parsing to be more robust about how union types are split. Add support for 'nullable' types.
Currently, we don't really support prose generation for compound types where the inner value is a union type. (Schema generation doesn't have this limitation and can handle these just fine.) The 'nullable' type is a bit of a hack for this specific instance, but for now it's good enough for the types that actually exist in the schema.