Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#494: Added measure support for the release operation #495

Closed
wants to merge 25 commits into from

Conversation

brynrhodes
Copy link
Member

This is a draft PR that implements Measure support in the Release operation. Additional changes include:

  • Improved dependency tracing in the Release operation to include non-owned components
  • Added support for non-owned components
  • Added a title element to the KnowledgeArtifactAdapter interface
  • Added a descriptor function to KnowledgeArtifactAdapter to provide a "display" element when writing a relatedArtifact

Current gaps in this implementation:

  • MeasureAdapter is only provided for R4, need DSTU3 and R5 support
  • The test is hardcoded to the ecqm-content-qicore-2024-subset repository, need to isolate the test resources and provide assertions
  • The "descriptor" implementation doesn't work properly right now
  • The relatedArtifact for CodeSystem resources that cannot be resolved should use the expansionParameters in the manifest, if it is present
  • CodeSystem and ValueSet references should also result in a "system-version" or "canonical-version" entry in the expansion parameters, respectively

Copy link

github-actions bot commented Jul 23, 2024

Formatting check succeeded!

TahaAttari and others added 12 commits July 24, 2024 14:41
- moved component reference updates into internalRelease
- created a dedicated resource cache for dependency resolution so it wouldn't get mixed up with the released resources
- updated tests with newly found dependencies
- make sure everything which can get a descriptor gets one
- update var names and comments
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 66.33761% with 341 lines in your changes missing coverage. Please review.

Project coverage is 62.57%. Comparing base (03d6a92) to head (d8bde26).
Report is 3 commits behind head on master.

Files Patch % Lines
...ds/cqf/fhir/utility/adapter/r4/MeasureAdapter.java 60.29% 67 Missing and 14 partials ⚠️
...ds/cqf/fhir/utility/adapter/r5/MeasureAdapter.java 60.29% 67 Missing and 14 partials ⚠️
...cqf/fhir/utility/adapter/dstu3/MeasureAdapter.java 54.87% 63 Missing and 11 partials ⚠️
...ava/org/opencds/cqf/fhir/utility/SearchHelper.java 53.48% 37 Missing and 3 partials ⚠️
...ility/visitor/KnowledgeArtifactReleaseVisitor.java 88.51% 6 Missing and 11 partials ⚠️
...cqf/fhir/utility/adapter/dstu3/LibraryAdapter.java 86.36% 3 Missing and 3 partials ⚠️
...ds/cqf/fhir/utility/adapter/r4/LibraryAdapter.java 86.36% 3 Missing and 3 partials ⚠️
...ds/cqf/fhir/utility/adapter/r5/LibraryAdapter.java 86.36% 3 Missing and 3 partials ⚠️
...tility/adapter/dstu3/KnowledgeArtifactAdapter.java 0.00% 4 Missing ⚠️
...r/utility/adapter/r4/KnowledgeArtifactAdapter.java 0.00% 4 Missing ⚠️
... and 11 more
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #495      +/-   ##
============================================
+ Coverage     62.22%   62.57%   +0.35%     
- Complexity     3585     3801     +216     
============================================
  Files           328      331       +3     
  Lines         17693    18578     +885     
  Branches       2728     2842     +114     
============================================
+ Hits          11009    11625     +616     
- Misses         5465     5688     +223     
- Partials       1219     1265      +46     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@TahaAttari TahaAttari marked this pull request as ready for review August 8, 2024 17:52
@TahaAttari
Copy link
Collaborator

I believe I've addressed all the gaps previously identified, remaining gaps are:

  • contained references aren't handled correctly, they should be prepended with the full canonical of the parent
  • when getting the latest version of an artifact we should be using a semver sort

And I plan to address these in future PRs

@TahaAttari
Copy link
Collaborator

closes #494

@TahaAttari
Copy link
Collaborator

superseded by #502

@TahaAttari TahaAttari closed this Aug 15, 2024
@JPercival JPercival deleted the feature-494-measure-release branch October 15, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants