Aphl 752 validate operation #747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TahaAttari
commented
Oct 24, 2023
TahaAttari
commented
Oct 24, 2023
plugin/cr/src/main/java/org/opencds/cqf/ruler/cr/KnowledgeArtifactProcessor.java
Show resolved
Hide resolved
TahaAttari
commented
Oct 24, 2023
Comment on lines
1234
to
1237
| // currently the packaged bundle is not valid due to: | ||
| // - bundle.total | ||
| // - bundle.entry.request | ||
| // being present on a bundle with type = collection |
There was a problem hiding this comment.
may need new profiles to avoid these validation failures
There was a problem hiding this comment.
Can't profile at the bundle level because of the possibility that the package will span multiple bundles.
There was a problem hiding this comment.
👍🏾 I'll split the test into individual validations on example resources to match our future workflow
There was a problem hiding this comment.
back to validating whole bundle based on discussion
sliver007
requested changes
Oct 27, 2023
Comment on lines
1234
to
1237
| // currently the packaged bundle is not valid due to: | ||
| // - bundle.total | ||
| // - bundle.entry.request | ||
| // being present on a bundle with type = collection |
There was a problem hiding this comment.
Can't profile at the bundle level because of the possibility that the package will span multiple bundles.
sliver007
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.