This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
#576: CQL 2.0.0 upgrade #581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # pom.xml
…ically create new tests based on the number of files in the directory.
|
This is good to go, @JPercival @brynrhodes |
JPercival
suggested changes
Jul 18, 2022
engine.fhir/src/main/java/org/opencds/cqf/cql/engine/fhir/model/Dstu2FhirModelResolver.java
Outdated
Show resolved
Hide resolved
engine.fhir/src/test/java/org/opencds/cqf/cql/engine/fhir/data/FhirExecutionTestBase.java
Outdated
Show resolved
Hide resolved
engine.fhir/src/test/java/org/opencds/cqf/cql/engine/fhir/data/TestFhirDataProviderDstu3.java
Outdated
Show resolved
Hide resolved
engine/src/main/java/org/opencds/cqf/cql/engine/elm/execution/CollapseEvaluator.java
Show resolved
Hide resolved
# Conflicts: # engine.fhir/pom.xml # engine.jaxb/pom.xml # engine/pom.xml
JPercival
approved these changes
Jul 19, 2022
|
I get failures running the dstu3 tests, can we add the "quick" package as a test dependency as well? That resolves it for me locally. Other than that this looks great, love the new testing approach! |
|
Interesting... I was waiting for the fhir-all module, but quick works |
|
@brynrhodes good to go! |
# Conflicts: # engine.fhir/pom.xml # engine.jaxb/pom.xml # engine/pom.xml # pom.xml
# Conflicts: # engine.fhir/src/test/java/org/opencds/cqf/cql/engine/fhir/model/TestDstu2ModelResolver.java
|
@JPercival good to go! |
7 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Testcases based on files in the directory, making it easier to debug.@Testcases based on test cases inside the XML files.@Testcase for everytest*statement in the libraryFixes: cqframework/clinical_quality_language#870, replaces #577