Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tauri 2.0 Support? #30

Closed
jaydevelopsstuff opened this issue Apr 13, 2024 · 9 comments · Fixed by #38
Closed

Tauri 2.0 Support? #30

jaydevelopsstuff opened this issue Apr 13, 2024 · 9 comments · Fixed by #38

Comments

@jaydevelopsstuff
Copy link

As far as I can tell these are the two roadblocks to getting this working with Tauri 2.0:

  • There are dependency conflicts with GTK related crates
  • HasRawWindowHandle is deprecated due to tauri-2.0.0-beta.3 upgrading to raw-window-handle 0.6.0.

Any plans to get this crate working with 2.0 Beta or are we waiting for a Release Candidate?
@lucasfernog-crabnebula
Copy link
Member

We were waiting on Tauri v2 to more stable to implement this. Basically we need a new crate that uses Tauri v2 instead of v1, and move the v1 crate out of the workspace.

jamesa08 added a commit to jamesa08/MIDIAnimator that referenced this issue Jun 2, 2024
@jamesa08
revert tauri 2.0 to 1.0
74e10e0 
reason:

drag-rs doesn't support 2.0 yet, and they're "waiting to stabilize" crabnebula-dev/drag-rs#30
jamesa08 added a commit to jamesa08/MIDIAnimator that referenced this issue Jun 2, 2024
@jamesa08
Revert "convert from tauri 1.0 to tauri 2.0"
bc1a8e9 
This reverts commit 69e88a3.

# Conflicts:
#	rust-impl/midianimator/src-tauri/capabilities/migrated.json
#	rust-impl/midianimator/src-tauri/gen/schemas/capabilities.json
#	rust-impl/midianimator/src-tauri/tauri.conf.json

Reason: drag-rs is waiting for Tauri 2.0 to stabilize. crabnebula-dev/drag-rs#30
@piotrostr
Copy link

We did get it to work in https://github.com/audiogenai/drag for OSX, Image param is not supported and some features might be limited but the drag and drop indeed works with v2-beta :)

@ayangweb
Copy link
Contributor

Hey👋, tauri v2 released a stable version, hope to support it soon!🌹

@lucasfernog-crabnebula
Copy link
Member

I'll take a look at this over the week :)

@ayangweb
Copy link
Contributor

ayangweb commented Oct 15, 2024 •
edited
Loading

Maybe I can try to provide a v2 version?

@lucasfernog
Copy link

Hey if you want to give it a try let me know how it goes :) i can at least help if you start a PR

@ayangweb
Copy link
Contributor

Ok, I'll adapt tauri v2 first, then you can do some optimization.

@lucasfernog
Copy link

should be pretty straightforward, i'm only worried about the gtk and windows dependencies updates

@ayangweb
Copy link
Contributor

ayangweb commented Oct 15, 2024 •
edited
Loading

tauri v2 one more plugin permission issue 🫣 dependency version issue can only be looked at while using it, I don't get it either

@lucasfernog-crabnebula lucasfernog-crabnebula linked a pull request Oct 15, 2024 that will close this issue
feat: support tauri v2 #38
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: support tauri v2 ayangweb/drag-rs
5 participants
@lucasfernog @piotrostr @jaydevelopsstuff @ayangweb @lucasfernog-crabnebula