-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support tauri v2 #38
Conversation
quite impressed with how far you got here, amazing work! i've been testing this on macOS and it's working well.. now we must verify Windows and Linux too |
Ok, no problem, I have windows and Linux VMs, I'll help you test it in my free time! |
i did notice the warning, it was there on the previous version too, that should be fine to adjust right @amr-crabnebula ? |
The iShot_2024-10-16_10.12.54.mp4 |
I can see what's the problem tomorrow.. looks like it's a deadlock? |
Linux works fine🥳
iShot_2024-10-16_10.19.54.mp4
iShot_2024-10-16_10.24.26.mp4 |
yeah feel free to fix it, it is just trying to read the |
Action on Linux does not pass, tauri v2 needs to download https://tauri.app/distribute/pipelines/github/#example-workflow |
@ayangweb i think you tested the main branch as the crates aren't even building yet on Linux and Windows 😂 |
Sorry, I did forget to switch branches 🤣 I'll go back and re-run the test later! |
funny that i did the same thing 😂 i can also do some tests / try to fix the builds later |
Windows works fine 🥳 The 10.16.mov |
I'm not sure it's this one pr related to |
Linux works fine 🥳 10.16.1.mov |
you must drag to an empty space like the desktop, it's working well on my end |
I think we're good to go, this is impressive!!!! |
As I #38 (comment) this demo, it does have problems! |
Maybe the window should spawn to where the mouse is? But this seems to be implemented by the users themselves iShot_2024-10-16_22.42.27.mp4 |
Every platform behaves differently, users just adapt themselves! 🤣 iShot_2024-10-16_22.46.16.mp4 |
No, I see that |
I couldn't reproduce it.. do you also face similar problems on the main branch? |
#38 (comment) It's the main branch. |
let's file a separate issue for it then, as i see this work as completed |
do you have a multi monitor setup? that might be the problem here, idk if the positioning work well in that case |
I don't have a multi-display connected, so let's open a separate issue to handle it! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
truly amazing work!
1f7818e
into
crabnebula-dev:main
I forgot to mention that I actually think we should create a new v2 branch merge! Or do you have something else in mind? |
@lucasfernog Need you to continue to optimize, thanks🌹