Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support tauri v2 #38

Merged
merged 24 commits into from
Oct 17, 2024
Merged

Conversation

ayangweb
Copy link
Contributor

@lucasfernog Need you to continue to optimize, thanks🌹

This was linked to issues Oct 15, 2024
@lucasfernog-crabnebula
Copy link
Member

quite impressed with how far you got here, amazing work! i've been testing this on macOS and it's working well.. now we must verify Windows and Linux too

@ayangweb
Copy link
Contributor Author

Ok, no problem, I have windows and Linux VMs, I'll help you test it in my free time!

@ayangweb
Copy link
Contributor Author

ayangweb commented Oct 16, 2024

It runs fine on Windows!

iShot_2024-10-16_10.03.41.mp4

There is a warning on Windows startup though, is this something that needs to be addressed?

iShot_2024-10-16_10 05 00

@lucasfernog
Copy link

i did notice the warning, it was there on the previous version too, that should be fine to adjust right @amr-crabnebula ?

@ayangweb
Copy link
Contributor Author

The tauri-plugin-drag-as-window plugin only supports opening windows by dragging them to the left, the windows generated on the right do not open!

iShot_2024-10-16_10.12.54.mp4

@lucasfernog
Copy link

I can see what's the problem tomorrow.. looks like it's a deadlock?

@ayangweb
Copy link
Contributor Author

Linux works fine🥳

tauri-plugin-drag

iShot_2024-10-16_10.19.54.mp4

tauri-plugin-drag-as-window

iShot_2024-10-16_10.24.26.mp4

@amr-crabnebula
Copy link
Contributor

i did notice the warning, it was there on the previous version too, that should be fine to adjust right @amr-crabnebula ?

yeah feel free to fix it, it is just trying to read the Result stored in a static variable.

@ayangweb
Copy link
Contributor Author

Action on Linux does not pass, tauri v2 needs to download libwebkit2gtk-4.1-dev.

https://tauri.app/distribute/pipelines/github/#example-workflow

@lucasfernog-crabnebula
Copy link
Member

@ayangweb i think you tested the main branch as the crates aren't even building yet on Linux and Windows 😂

@ayangweb
Copy link
Contributor Author

@ayangweb i think you tested the main branch as the crates aren't even building yet on Linux and Windows 😂

Sorry, I did forget to switch branches 🤣 I'll go back and re-run the test later!

@lucasfernog-crabnebula
Copy link
Member

funny that i did the same thing 😂 i can also do some tests / try to fix the builds later

@ayangweb
Copy link
Contributor Author

Windows works fine 🥳

The tauri-plugin-drag-as-window window doesn't show, I think it's a postions issue?

10.16.mov

@ayangweb
Copy link
Contributor Author

image

I'm not sure it's this one pr related to

@ayangweb
Copy link
Contributor Author

Linux works fine 🥳

10.16.1.mov

@lucasfernog-crabnebula
Copy link
Member

Windows works fine 🥳

The tauri-plugin-drag-as-window window doesn't show, I think it's a postions issue?

10.16.mov

you must drag to an empty space like the desktop, it's working well on my end

@lucasfernog-crabnebula
Copy link
Member

I think we're good to go, this is impressive!!!!

@ayangweb
Copy link
Contributor Author

I think we're good to go, this is impressive!!!!

As I #38 (comment) this demo, it does have problems!

@ayangweb
Copy link
Contributor Author

ayangweb commented Oct 16, 2024

Maybe the window should spawn to where the mouse is? But this seems to be implemented by the users themselves

iShot_2024-10-16_22.42.27.mp4

@ayangweb
Copy link
Contributor Author

Every platform behaves differently, users just adapt themselves! 🤣

iShot_2024-10-16_22.46.16.mp4

@ayangweb
Copy link
Contributor Author

No, I see that x and y are returned by dragAsWindow, without looking closely at the code I thought it was taken directly by the js

@lucasfernog-crabnebula
Copy link
Member

I think we're good to go, this is impressive!!!!

As I #38 (comment) this demo, it does have problems!

I couldn't reproduce it.. do you also face similar problems on the main branch?

@ayangweb
Copy link
Contributor Author

I think we're good to go, this is impressive!!!!

As I #38 (comment) this demo, it does have problems!

I couldn't reproduce it.. do you also face similar problems on the main branch?

#38 (comment) It's the main branch.

@lucasfernog-crabnebula
Copy link
Member

let's file a separate issue for it then, as i see this work as completed

@lucasfernog-crabnebula
Copy link
Member

do you have a multi monitor setup? that might be the problem here, idk if the positioning work well in that case

@ayangweb
Copy link
Contributor Author

I don't have a multi-display connected, so let's open a separate issue to handle it!

Copy link
Member

@lucasfernog-crabnebula lucasfernog-crabnebula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

truly amazing work!

@lucasfernog-crabnebula lucasfernog-crabnebula merged commit 1f7818e into crabnebula-dev:main Oct 17, 2024
9 of 10 checks passed
@ayangweb
Copy link
Contributor Author

ayangweb commented Oct 17, 2024

I forgot to mention that I actually think we should create a new v2 branch merge! Or do you have something else in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade to raw-window-handle 0.6.1 Tauri 2.0 Support?
4 participants