Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PlaceholderManager.java #42

Closed
wants to merge 4 commits into from

Conversation

Yesitics
Copy link

@Yesitics Yesitics commented Apr 4, 2024

Adjusted the PlaceholderManager to display maximum claims if the claims are empty.

@SpraxDev SpraxDev self-assigned this Apr 5, 2024
@SpraxDev SpraxDev requested a review from ceze88 April 6, 2024 08:10
@SpraxDev SpraxDev changed the base branch from master to development April 6, 2024 08:25
@SpraxDev
Copy link
Member

SpraxDev commented Apr 6, 2024

Hi @Yesitics, thanks for your interest in contributing to our project.

  1. I've changed the target branch of your commit to development and rebased your branch on it (hence the force-push).
    Please create your PRs against it in the future (we'll add some info for that in the future so people actually know about that).
  2. I've added missing import statements for your changes while I was at it already

BUT the code currently doesn't compile. You might have confused a + with : maybe because a : for the ternary operator is missing and breaking the code.

I've requested a code review from @ceze88, so when the code is fixed and the project can compile again he can check the changes and merge them 😃

@SpraxDev SpraxDev assigned ceze88 and unassigned SpraxDev Apr 6, 2024
@Yesitics Yesitics closed this by deleting the head repository Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants