Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show JobInterface::getDescription() for queue/run -v #2355

Merged
merged 4 commits into from
Jan 26, 2018
Merged

Show JobInterface::getDescription() for queue/run -v #2355

merged 4 commits into from
Jan 26, 2018

Conversation

ostark
Copy link
Contributor

@ostark ostark commented Jan 25, 2018

Similar to the output in the CP, the verbose output of the ./craft queue/run -v command should include the job description. This can be more meaningful than the class name.

before 🤔

./craft queue/run -v
2018-01-25 23:14:41 [29] ostark\upper\jobs\PurgeCacheJob (attempt: 1) - Started
2018-01-25 23:14:41 [29] ostark\upper\jobs\PurgeCacheJob (attempt: 1) - Done (0.001 s)
2018-01-25 23:14:41 [30] craft\queue\jobs\DeleteStaleTemplateCaches (attempt: 1) - Started
2018-01-25 23:14:41 [30] craft\queue\jobs\DeleteStaleTemplateCaches (attempt: 1) - Done (0.002 

after 😎

 ./craft queue/run -v
2018-01-25 23:15:59 [31] Purge Tag: el74 (attempt: 1) - Started
2018-01-25 23:15:59 [31] Purge Tag: el74 (attempt: 1) - Done (0.002 s)
2018-01-25 23:15:59 [32] Deleting stale template caches (attempt: 1) - Started
2018-01-25 23:15:59 [32] Deleting stale template caches (attempt: 1) - Done (0.003 s)

@ostark
Copy link
Contributor Author

ostark commented Jan 26, 2018

If this PR makes sense to you, I would love go futher and provide a 'fix' for the queue.log, which is kind of useless at the moment: Currently there is just noise and actual queue messages don't get logged at all.

@brandonkelly brandonkelly merged commit e1d7677 into craftcms:develop Jan 26, 2018
@brandonkelly
Copy link
Member

Like the improvement, thanks! Happy to review other related PRs.

brandonkelly added a commit that referenced this pull request Jan 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants