if we don't have extension, don't add a full stop to the filename

craftcms · Sep 4, 2024 · 49a35a4 · 49a35a4
1 parent e28b876
commit 49a35a4
Showing 1 changed file with 8 additions and 1 deletion.
diff --git a/src/fields/Assets.php b/src/fields/Assets.php
@@ -181,7 +181,14 @@ public function parseField(): mixed
                     $urlsToUpload[$key]['value'] = $dataValue;
 
                     if (isset($filenamesFromFeed[$key])) {
-                        $filename = $filenamesFromFeed[$key] . '.' . AssetHelper::getRemoteUrlExtension($urlsToUpload[$key]['value']);
+                        $filename = $filenamesFromFeed[$key];
+
+                        // if we can determine the extension of the remote file, use that extension
+                        $remoteUrlExtension = AssetHelper::getRemoteUrlExtension($urlsToUpload[$key]['value']);
+                        if (!empty($remoteUrlExtension)) {
+                            $filename .= '.' . $remoteUrlExtension;
+                        }
+
                         $urlsToUpload[$key]['newFilename'] = $filename;
                     } else {
                         $filename = AssetHelper::getRemoteUrlFilename($dataValue);