MongoDB: Fix timestamp conversion #58
Closed
+18
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
refinements-1
branch
from
b844f03
to
5370381
Compare
amotl
force-pushed
the
collab/mongodb-fix-timestamp-conversion
branch
from
c13b2f0
to
c33fdc9
Compare
amotl
commented
Sep 25, 2024
Comment on lines
-166
to
+165
| return calendar.timegm(datetime.utctimetuple()) | ||
| return datetime.timestamp() |
There was a problem hiding this comment.
The previous instruction behaves better in all situations, as it produces the same results even when invoked on systems running different time zones.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Swap instruction to encode datetime values to unix time.
Originally, the previous code is coming from the implementation of
migr8, specifically itsdate_converter, see migr8/export.py#L52, added by @autophagy with crate/mongodb-cratedb-migration-tool@544c4974cf8.Thoughts
While reviewing the code base, I may have discovered a minor flaw with timestamp conversions. On the other hand, I might also be wrong on this. What do you think about it?