better catch unauthorized errors with forced password prompt

crate · Jan 30, 2024 · 924f224 · 924f224
1 parent ce39a5c
commit 924f224
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 9 deletions.
diff --git a/CHANGES.txt b/CHANGES.txt
@@ -5,6 +5,8 @@ Changes for crash
 Unreleased
 ==========
 
+- Better catch unauthorized errors when forcing a password prompt.
+
 2024/01/29 0.31.0
 =================
 

diff --git a/crate/crash/command.py b/crate/crash/command.py
@@ -580,17 +580,17 @@ def main():
                             args, password=password)
     except (ProgrammingError, LocationParseError) as e:
         msg = getattr(e, 'message', str(e))
-        if '401' in msg and not args.force_passwd_prompt:
-            if is_tty:
+        if '401' in msg and not args.force_passwd_prompt and is_tty:
                 password = getpass()
-            try:
-                cmd = _create_shell(crate_hosts, error_trace, output_writer,
-                                    is_tty, args, password=password)
-            except (ProgrammingError, LocationParseError) as ex:
-                printer.warn(str(ex))
-                sys.exit(1)
+                try:
+                    cmd = _create_shell(crate_hosts, error_trace, output_writer,
+                                        is_tty, args, password=password)
+                except (ProgrammingError, LocationParseError) as ex:
+                    printer.warn(str(ex))
+                    sys.exit(1)
         else:
-            raise e
+            printer.warn(str(e))
+            sys.exit(1)
     except Exception as e:
         printer.warn(str(e))
         sys.exit(1)