Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use verlib2.Version instead of crate.client._pep440.Version #422

Merged
merged 1 commit into from
Jan 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion crate/crash/command.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,9 +37,9 @@
import urllib3
from platformdirs import user_config_dir, user_data_dir
from urllib3.exceptions import LocationParseError
from verlib2 import Version

from crate.client import connect
from crate.client._pep440 import Version
from crate.client.exceptions import ConnectionError, ProgrammingError

from ..crash import __version__ as crash_version
Expand Down
2 changes: 1 addition & 1 deletion crate/crash/commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
import os
from collections import OrderedDict

from crate.client._pep440 import Version
from verlib2 import Version


class Command(object):
Expand Down
2 changes: 1 addition & 1 deletion crate/crash/sysinfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@

from collections import namedtuple

from crate.client._pep440 import Version
from verlib2 import Version

Result = namedtuple('Result', ['rows', 'cols'])
SYSINFO_MIN_VERSION = Version("0.54.0")
Expand Down
3 changes: 2 additions & 1 deletion setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,8 @@
'platformdirs<5',
'prompt-toolkit>=3.0,<4',
'tabulate>=0.9,<0.10',
'sqlparse>=0.4.4,<0.5.0'
'sqlparse>=0.4.4,<0.5.0',
'verlib2<0.3',
]


Expand Down
3 changes: 2 additions & 1 deletion tests/test_command.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,8 @@

from unittest import TestCase

from crate.client._pep440 import Version
from verlib2 import Version

from crate.crash.command import (
Result,
get_information_schema_query,
Expand Down
3 changes: 2 additions & 1 deletion tests/test_commands.py
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,8 @@
from unittest import SkipTest, TestCase
from unittest.mock import MagicMock, call, patch

from crate.client._pep440 import Version
from verlib2 import Version

from crate.crash.command import CrateShell
from crate.crash.commands import (
CheckCommand,
Expand Down
3 changes: 2 additions & 1 deletion tests/test_sysinfo.py
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,8 @@
from unittest import TestCase
from unittest.mock import PropertyMock, patch

from crate.client._pep440 import Version
from verlib2 import Version

from crate.crash.command import CrateShell
from crate.crash.sysinfo import Result as Res, SysInfoCommand

Expand Down