Fix dependencies for testing #435
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geojson was missing, while it should be there. No idea why that happens. geojson is a dependency of crate[sqlalchemy]. It looks like we need to be more explicit here.
BaurzhanSakhariev
approved these changes
Mar 19, 2024
matriv
approved these changes
Mar 19, 2024
|
Another similar issue has popped up https://github.com/crate/crate-alerts/issues/628
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/crate/crate-alerts/issues/626
About
geojson was missing, while it should be there. No idea why that happens.
geojsonis a valid dependency ofcrate[sqlalchemy], which, in turn, should have been installed on behalf ofcratedb-toolkit[test]. It looks like we need to be more explicit here, and otherwise also investigate further about the root cause.For a quick measure, this patch should fix the failing nightly test job right away.
References