Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement sharding calculator #628

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

SilPan
Copy link

@SilPan SilPan commented Jun 30, 2019

If there was a general decision against using it just ignore this PR.

Summary of the changes / Why this is an improvement

So this is the sharding calculator as developed by Seonghye, Floyd and me. It got never merged either because of trouble with the git flow or because it was decided against it.
The git flow is what I fixed now, I needed something to procrastinate with instead of studying for my exams.
So if it was not merged because of troubles with our git flow, that should be fixed now.
The whole project is now squashed into one single commit, as required and rebased onto master.

In case anyone actually wants to use it be aware of these things:

  • Take a look at the CHANGES.txt, this is probably not how you want it!
  • This thing implements a SQL Injection, because it uses String concatenation to build queries. This should not be a problem, since crate-admin allows one to make arbitrary SQL queries anyway. But the fact should be considered if there would be setup a demo where the later feature is disabled somehow.
  • It makes changes to app/scripts/filter/numbers.js to be compliant to the International Standard of Units (e.g. KiloByte -> KibiByte). This is probably unwanted.

Checklist

  • CLA is signed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant