-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maintenance: Update to Python 3.11 #549
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please go with 3.10 first - 3.11 is still a bit on the bleeding edge with some libraries being incompatible.
setup.py
Outdated
"aiopg==1.4.0", | ||
"bitmath==1.3.3.1", | ||
"kopf==1.35.6", | ||
"aiopg<1.5", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Due to there not being a lockfile for setuptools, I am strongly against pinning version ranges - this eventually leads to some library releasing a patch version that breaks backwards compatibility accidentally and you no longer have predictable builds. Let's leave it like it was please.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the pinning of version ranges again.
Hi Romanas. Thanks. I was just playing around a bit, and I do not plan to submit this patch as a proposal for integration. Can you share some pointers to the libraries being incompatible with Python 3.11 in one way or another, if you may know about the right spots already? It will tremendously help to get a better understanding. |
I only have anecdotal evidence, i.e. when we were trying to upgrade to 3.11 in the cloud-api, there were issues with celery. That made me come to a mental conclusion "3.11 is too early for us" and forget about it. |
bcac5a6
to
7ede699
Compare
References about mypy modernizations, re. |
@amotl do you plan working on this one ? |
Hi @goat-ssh. I can give the patch another refresh if there is interest. |
79467c2
to
6012be3
Compare
mypy needs to be bumped first I guess. |
About
Just a humble attempt to modernize the Python version and the package dependencies.
Notes
Needs more love on different levels.