Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove stock JDBC client tests #278

Closed
wants to merge 1 commit into from
Closed

Remove stock JDBC client tests #278

wants to merge 1 commit into from

Conversation

mfussenegger
Copy link
Member

The integration tests in the crate repo already use the stock PostgreSQL
JDBC client.

The integration tests in the crate repo already use the stock PostgreSQL
JDBC client.
@matriv
Copy link
Contributor

matriv commented Oct 4, 2023

I'd say to not remove those, as very recently helped us identify an issue: crate/crate#14754. What do you think?

Copy link
Member

@amotl amotl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi.

We converged that code into the cratedb-examples repository the other day, so I think it will be good to remove it here.

I'd say to not remove those, as very recently helped us identify an issue.

I agree. There might just be a new issue upcoming, which has been caught when upgrading org.postgresql:postgresql from 42.6.0 to 42.7.0.

With kind regards,
Andreas.

@amotl amotl requested review from seut and matriv November 29, 2023 13:00
@matriv
Copy link
Contributor

matriv commented Nov 30, 2023

Apologies, but I don't agree to remove the tests from here, crate-qa CI is something that we monitor closely and indicates possible issues when we change things in CrateDB. Whereas cratedb-examples has a completely different purpose, it's to show basic usage of various integrations and it's not connected to CrateDB dev lifecycle.

@amotl
Copy link
Member

amotl commented Nov 30, 2023

All right. So, let's close this PR and maybe let's also add some Dependabot configurations to the QA tests here, so that errors like currently happening at GH-288 can be caught earlier in the future?

Do you have any strong objections, @mfussenegger?

@matriv
Copy link
Contributor

matriv commented Nov 30, 2023

Do you have any strong objections, @mfussenegger?

Yep, let's here other's opinion on this one before closing, thx!

@mfussenegger
Copy link
Member Author

The idea would've been to extend the tests in crate/crate to fill in any gaps.
Having more tests is good, having redundant test cases not so much.

But probably makes sense to keep it here, given that JdbcMetaDataTest is very client specific.

@mfussenegger mfussenegger deleted the j/stock-jdbc branch December 4, 2023 09:40
@matriv
Copy link
Contributor

matriv commented Dec 4, 2023

Totally agree to try to move the stuff that makes sense to crate/crate repo and here only have smoke tests if necessary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants