Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Make subprocess.check_call not suppress its output #314

Merged
merged 1 commit into from
Feb 22, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 21, 2024

Problem

It is hard to debug GH-313 when not being able to observe any stderr output from the child process.

@amotl
Copy link
Member Author

amotl commented Feb 21, 2024

superset db upgrade also fails here. I don't know why. At least, there is a traceback now.

-- https://github.com/crate/cratedb-examples/actions/runs/7997153563/job/21841038825?pr=314#step:7:290

@amotl amotl marked this pull request as ready for review February 22, 2024 13:56
@amotl amotl merged commit 956cacb into main Feb 22, 2024
1 of 2 checks passed
@amotl amotl deleted the amo/fix-check-call branch February 22, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant