Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content: Forward-port changes from crate-tutorials repository #13

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

amotl
Copy link
Member

@amotl amotl commented Feb 14, 2024

About

This patch forward-ports of a few changes made to the crate-tutorials repository after converging its content into crate-guide the other day.

Details

This patch includes commits from relevant patches to crate-tutorials.

Review

You might have seen those changes already ;]. Please check once again if everything is in order. Thanks!

@amotl amotl marked this pull request as ready for review February 14, 2024 00:35
Comment on lines +29 to +31
# Add CrateDB repository to Apt
echo "deb https://cdn.crate.io/downloads/debian/stable/ default main" | \
sudo tee /etc/apt/sources.list.d/crate-stable.list
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Debian repository location is https://cdn.crate.io/downloads/debian/.

Comment on lines 26 to 27
curl -sS https://cdn.crate.io/downloads/apt/DEB-GPG-KEY-crate | \
sudo tee /etc/apt/trusted.gpg.d/cratedb.asc
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can also have the key at https://cdn.crate.io/downloads/debian/DEB-GPG-KEY-crate?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, but can we store it just in one place and use redirects/symlinks?

Copy link
Member Author

@amotl amotl Feb 14, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The situation on the server machine is like that both folders include separate but identical representations of that GPG public key.

Also, I haven't been able to find the root source of the DEB-GPG-KEY-crate file within any of our repositories. In this spirit, because I am unsure where to target the symlink to, and in order to keep things self-contained, I copied that file to the debian folder as well. Now we have it:

Please advise if things should be handled differently.

Comment on lines 26 to 27
curl -sS https://cdn.crate.io/downloads/apt/DEB-GPG-KEY-crate | \
sudo tee /etc/apt/trusted.gpg.d/cratedb.asc
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, but can we store it just in one place and use redirects/symlinks?

@mfussenegger
Copy link
Member

Do I get this right that we have three different locations where we explain how to setup a debian repository?

Can we consolidate this to one?

@amotl
Copy link
Member Author

amotl commented Feb 14, 2024

Yes. cratedb-guide is the consolidation point I guess, not only about installation concerns.

mfussenegger and others added 3 commits February 14, 2024 23:31
We now have a repository that only contains a single `default`
distribution, because the package is generic enough to works across all
recent Ubuntu and Debian releases.

The new repository includes old versions in the `Packages` index to
allow users to install old versions via `apt install crate=x.y.z`

It also contains ARM64 packages.
@amotl amotl merged commit 3d63267 into main Feb 19, 2024
3 checks passed
@amotl amotl deleted the amo/forward-ports branch February 19, 2024 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants