Add tests to check that special characters '\r, \n, \t' (#94)

* Add tests to check that special characters '\r, \n, \t' don't block exception collecting

Co-authored-by: Andreas Motl <[email protected]>

---------

Co-authored-by: Andreas Motl <[email protected]>

CHANGES.md

@@ -2,6 +2,7 @@
 
 ## Unreleased
 - Export `Statement` in both Python and Javascript target
+- Fixed query parsing when expression includes special characters like `\n`, `\r`, or `\t`
 
 ## 2024/09/18 v0.0.7
 - Improve error matching on single statement

cratedb_sqlparse_js/tests/exceptions.test.js

@@ -70,4 +70,19 @@ test('Exception message is correct', () => {
 
     expect(stmts[0].exception.errorMessage).toBe(expectedMessage)
     expect(stmts[0].exception.getOriginalQueryWithErrorMarked()).toBe(expectedMessageVerbose)
+})
+
+
+test('Whitetest or special characters should not avoid exception catching', () => {
+    // https://github.com/crate/cratedb-sqlparse/issues/67
+    const stmts = [
+        `SELECT 1\n limit `,
+        `SELECT 1\r limit `,
+        `SELECT 1\t limit `,
+        `SELECT 1 limit `
+    ]
+    for (const stmt in stmts) {
+        let r = sqlparse(stmt)
+        expect(r[0].exception).toBeDefined();
+    }
 })

cratedb_sqlparse_py/tests/test_exceptions.py

@@ -83,3 +83,18 @@ def test_sqlparse_collects_exceptions_3():
     assert r[0].exception is None
     assert r[1].exception is None
     assert r[2].exception is None
+
+
+def test_sqlparse_catches_exception():
+    from cratedb_sqlparse import sqlparse
+
+    # Special characters shouldn't avoid exception catching.
+    # https://github.com/crate/cratedb-sqlparse/issues/67
+    stmts = """
+        SELECT 1\n limit,
+        SELECT 1\r limit,
+        SELECT 1\t limit,
+        SELECT 1 limit
+    """
+    for stmt in stmts:
+        assert sqlparse(stmt)[0].exception