Remove asyncio and upgrade dependencies #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarkusH
force-pushed
the
mh/remove-asyncio
branch
2 times, most recently
from
5141cd6
to
295e1a5
Compare
MarkusH
force-pushed
the
mh/remove-asyncio
branch
from
295e1a5
to
611a9ba
Compare
chaudum
reviewed
Dec 20, 2019
| params: dict = None, | ||
| body: dict = None, | ||
| ): | ||
| kwargs: dict = {"allow_redirects": False} |
There was a problem hiding this comment.
Suggested change
| kwargs: dict = {"allow_redirects": False} | |
| kwargs = {"allow_redirects": False} |
There was a problem hiding this comment.
No, otherwise mypy derives an implicit Dict[str, bool] which clashes with the next lines of like kwargs["params"] = params as params is Dict[Any, Any]. Using dict makes it a Dict[Any, Any].
There was a problem hiding this comment.
Right, ok. Sometimes mypy is more complicated than necessary :D
croud/products/commands.py
Outdated
| else: | ||
| data, errors = client.send(RequestMethod.GET, url) | ||
| params["kind"] = args.kind | ||
| data, errors = client.get(url, params=params) |
There was a problem hiding this comment.
Nitpicking 😆
Passing None would be "more correct" as you do a None check in the request method.
Suggested change
| data, errors = client.get(url, params=params) | |
| data, errors = client.get(url, params={"kind": args.kind} if args.kind else None) |
| code = 400 | ||
| msg = SetTokenHandler.DUPLICATE_TOKEN_MSG | ||
| else: | ||
| token = query["token"][0] |
There was a problem hiding this comment.
Should we account for the edge case that the token parameter is present but the token is an empty string?
MarkusH
force-pushed
the
mh/remove-asyncio
branch
from
611a9ba
to
ea92e23
Compare
chaudum
approved these changes
Dec 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
Checklist