Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust software tests for CrateDB #10

Merged
merged 11 commits into from
Sep 12, 2023
Merged

Adjust software tests for CrateDB #10

merged 11 commits into from
Sep 12, 2023

Conversation

amotl
Copy link
Member

@amotl amotl commented Sep 9, 2023

About

Add software tests for GH-5, based on the corresponding vanilla MLflow test cases added with GH-6.

Details

  • All tests specific to SQLite and database migrations have been removed.
  • With CrateDB's SQLAlchemy polyfill for translating autoincrement column constraints, experiment identifiers are no longer small incrementing integers, but rather wider integers, randomly generated. A few spots need to compensate for that. Specifically, using get_experiment_by_name instead of get_experiment at a few spots made the transition very easy.
  • Database tables are now pruned on test setup instead of teardown, in order to make it possible to inspect the database on failed test runs.
  • Skip a few test cases still failing.
  • Slow tests have been marked with pytest.mark.slow. Running poe check-fast will omit them.

Backlog: Fix more tests

@amotl amotl marked this pull request as ready for review September 9, 2023 15:06
@amotl amotl changed the title Adjust software tests Adjust software tests for CrateDB Sep 9, 2023
Base automatically changed from add-tests to main September 12, 2023 10:35
@amotl amotl merged commit d52a2c3 into main Sep 12, 2023
1 check passed
@amotl amotl deleted the adjust-tests branch September 12, 2023 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant