Fixed SQL rendering of special DDL table options in CrateDDLCompiler.
#141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
amotl
force-pushed
the
amo/fix-table-dialect-options
branch
from
9378b89
to
5b9f9e6
Compare
Configuring special table options like `crate_"translog.durability"` was
not possible, because they got rendered into SQL DDL in uppercase
letters. That fails like:
SQLParseException[Invalid property "TRANSLOG.DURABILITY" passed to
[ALTER | CREATE] TABLE statement]
amotl
force-pushed
the
amo/fix-table-dialect-options
branch
from
5b9f9e6
to
1357ae0
Compare
seut
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Configuring special table options like
crate_"translog.durability"was not possible, because they got rendered into SQL DDL in uppercase letters. That fails like: