Add quote_relation_name support utility function
#155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amotl
force-pushed
the
amo/support-table-quoting
branch
2 times, most recently
from
4ac3451
to
b1e4e37
Compare
proddata
reviewed
Aug 27, 2024
amotl
force-pushed
the
amo/support-table-quoting
branch
from
b1e4e37
to
fab6f4b
Compare
amotl
force-pushed
the
amo/support-table-quoting
branch
from
fab6f4b
to
a80fb4d
Compare
amotl
force-pushed
the
amo/support-table-quoting
branch
from
a80fb4d
to
99ee4cc
Compare
proddata
approved these changes
Aug 29, 2024
matriv
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
LGTM, thx!
Some more info, but I don't think it's necessary for the purpose of this PR:
In CrateDB, we use some extra checks to judge if quoting is necessary: https://github.com/crate/crate/blob/master/libs/sql-parser/src/main/java/io/crate/sql/Identifiers.java#L88
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
The
quote_relation_namesupport utility function is required in other packages than cratedb-toolkit. Because cratedb-toolkit is too heavy to be pulled into smaller packages, let's break it out of it.References
/cc @wierdvanderhaar, @hlcianfagna, @karynzv, @juanpardo, @tomach, @Taliik, @proddata