Chore: Fix package entrypoint and module imports after migration from crate-python #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The dialect as designated by the `crate` dialect identifier was still pointing to the `crate` package. Now, it is assigned to this one instead.
amotl
changed the title
- Package metadata now maintained within `pyproject.toml` - Use `build` package for building packages instead of `wheel`
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #67 +/- ##
==========================================
+ Coverage 84.64% 84.65% +0.01%
==========================================
Files 14 14
Lines 918 919 +1
==========================================
+ Hits 777 778 +1
Misses 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
surister
approved these changes
Jun 10, 2024
seut
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About
Another few maintenance adjustments in the spirit of GH-66.
Details
Those are aftermath fixes, and intended to be included into an initial release of this package, before adding any other features.
More
Along the lines, 5d274c3 also updates the CI/GHA job for staging release packages to PyPI.