Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration: add proxy test for all platforms #3684

Merged
merged 1 commit into from
Jul 18, 2023

Conversation

jsliacan
Copy link
Contributor

User mode on all platforms. System mode on linux is used for the e2e proxy test (dedicated to linux). So here we complement that.

@jsliacan jsliacan self-assigned this May 30, 2023
@anjannath
Copy link
Member

/test integration-crc

@anjannath
Copy link
Member

tests are passing locally:

⠀ ➜  crc git:(74b64c8a) make BUNDLE_PATH=/home/anjan/Downloads/bundles/crc_libvirt_4.13.0_amd64.crcbundle PULL_SECRET_PATH=/home/anjan/Downloads/pull-secret GINKGO_OPTS="--ginkgo.label-filter \"goproxy\"" integration
=== RUN   TestTest
Running Suite: Test Suite - /home/anjan/Work/github.com/code-ready/crc/test/integration
=======================================================================================
Random Seed: 1685519925

Will run 6 of 36 specs
•••••[sudo] password for anjan:
•SSSSSSSSSSSSSSSSSSSSSSSSSSSSSS

Ran 6 of 36 Specs in 1300.045 seconds
SUCCESS! -- 6 Passed | 0 Failed | 0 Pending | 30 Skipped
--- PASS: TestTest (1300.05s)
PASS
ok      github.com/crc-org/crc/test/integration 1300.080s

@jsliacan jsliacan force-pushed the goproxy branch 3 times, most recently from 24977bc to f16d394 Compare June 13, 2023 08:53
proxy := goproxy.NewProxyHttpServer()
proxy.OnRequest(goproxy.ReqHostMatches(regexp.MustCompile("^.*$"))).HandleConnect(goproxy.AlwaysMitm)

logfile := filepath.Join("test", "integration", "out", "goproxylogfile.log")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gbraad
Copy link
Contributor

gbraad commented Jul 5, 2023

lets have this merged soon

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

@jsliacan: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-crc 77e70f1 link true /test e2e-crc

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci
Copy link

openshift-ci bot commented Jul 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anjannath, gbraad

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@anjannath anjannath merged commit e43de8d into crc-org:main Jul 18, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants