-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add implementation of Server-Sent Events (SSE) #3700
Conversation
feels almost like a drop-in replacement. |
Can you reference the issue this is related to ? |
This also works on Windows? |
Only CPU and memory are updated:
See #3744 |
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
Signed-off-by: Yevhen Vydolob <[email protected]>
@evidolob: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how to implement this for the extension?
and followup with #3744 to include state
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: gbraad The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: Issue #N
Relates to: Issue #N, PR #N, ...
Solution/Idea
This PR provides implementation of server sent events. This implementation is used to replace existing WebSocket implementation. Currently only
status
event channel is used for fetchingcrc status -w
data.Also PR provide
logs
event channel on which daemon publish all logs collected bylogrus
logger, it will be used in future work for moving all crc command execution to daemon, as will allow to keep current cli behaviour/output.Test
You could use
curl
to view events:curl -GET -i --unix-socket <path to crc socket>/crc-http.sock "http://localhost/events?stream=logs"
to view logs events.curl -GET -i --unix-socket <path to crc socket>/crc-http.sock "http://localhost/events?stream=status"
to view data which used forcrc status -w
.crc status -w
should work exactly as before.