Remove wrong assertions.

These assertions were added in e9c0e22, but they are *not* correct. A type size of 1 (e.g. `char`) can be encountered, and it is a valid case that simply does not support any byte swapping. (Another case had already been fixed in 11e56d6.)
cristian64 · May 16, 2024 · 6929fbe · 6929fbe
1 parent 8936d78
commit 6929fbe
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 10 deletions.
diff --git a/Source/DolphinProcess/Linux/LinuxDolphinProcess.cpp b/Source/DolphinProcess/Linux/LinuxDolphinProcess.cpp
@@ -4,7 +4,6 @@
 #include "../../Common/CommonUtils.h"
 #include "../../Common/MemoryCommon.h"
 
-#include <cassert>
 #include <cstdlib>
 #include <cstring>
 #include <dirent.h>
@@ -204,7 +203,6 @@ bool LinuxDolphinProcess::readFromRAM(const u32 offset, char* buffer, const size
       break;
     }
     default:
-      assert(0 && "Unexpected type size");
       break;
     }
   }
@@ -272,7 +270,6 @@ bool LinuxDolphinProcess::writeToRAM(const u32 offset, const char* buffer, const
       break;
     }
     default:
-      assert(0 && "Unexpected type size");
       break;
     }
   }

diff --git a/Source/DolphinProcess/Mac/MacDolphinProcess.cpp b/Source/DolphinProcess/Mac/MacDolphinProcess.cpp
@@ -4,7 +4,6 @@
 #include "../../Common/CommonUtils.h"
 #include "../../Common/MemoryCommon.h"
 
-#include <cassert>
 #include <cstdlib>
 #include <mach/mach_vm.h>
 #include <memory>
@@ -171,7 +170,6 @@ bool MacDolphinProcess::readFromRAM(const u32 offset, char* buffer, size_t size,
       break;
     }
     default:
-      assert(0 && "Unexpected type size");
       break;
     }
   }
@@ -231,7 +229,6 @@ bool MacDolphinProcess::writeToRAM(const u32 offset, const char* buffer, const s
       break;
     }
     default:
-      assert(0 && "Unexpected type size");
       break;
     }
   }

diff --git a/Source/DolphinProcess/Windows/WindowsDolphinProcess.cpp b/Source/DolphinProcess/Windows/WindowsDolphinProcess.cpp
@@ -8,7 +8,6 @@
 #ifdef UNICODE
 #include <codecvt>
 #endif
-#include <cassert>
 #include <cstdlib>
 #include <string>
 #include <tlhelp32.h>
@@ -207,7 +206,6 @@ bool WindowsDolphinProcess::readFromRAM(const u32 offset, char* buffer, const si
         break;
       }
       default:
-        assert(0 && "Unexpected type size");
         break;
       }
     }
@@ -268,7 +266,6 @@ bool WindowsDolphinProcess::writeToRAM(const u32 offset, const char* buffer, con
       break;
     }
     default:
-      assert(0 && "Unexpected type size");
       break;
     }
   }

diff --git a/Source/MemoryScanner/MemoryScanner.h b/Source/MemoryScanner/MemoryScanner.h
@@ -1,6 +1,5 @@
 #pragma once
 
-#include <cassert>
 #include <cmath>
 #include <cstring>
 #include <stack>