forked from aldelaro5/dolphin-memory-engine
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Treat failed save actions as cancel actions.
Previously, if the user exited the file browser dialog without saving the file (voluntarily, or due to I/O error), DME would still exit (or wipe out the watch model; depending on the case), causing unrecoverable data loss. Test plan: - Launch DME. - Add a few watch entries to mark the model with unsaved changes. - Clear the watch list via the **File > Clear the watch list** action. - A confirmation dialog with the **Cancel**, **No**, and **Yes** options should appear. - Click **Yes** - Once the file browser dialog opens, close it without selecting a file (or choose a filepath where the user does not have write permissions). Previous behavior: The watch list was wrongly cleared, without the user having saved it. New behavior: The user gets back to DME, as if **Cancel** had been selected in the confirmation dialog.
- Loading branch information
1 parent
d0abec0
commit 6fc6691
Showing
2 changed files
with
11 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters