Add MemWatchTreeNode::deleteChildren() method.

Unlike `removeChildren()` (previously `clearAllChild()`), this method does free the memory of the removed children.
cristian64 · May 17, 2024 · 78b621e · 78b621e
1 parent 96264a5
commit 78b621e
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/Source/MemoryWatch/MemWatchTreeNode.cpp b/Source/MemoryWatch/MemWatchTreeNode.cpp
@@ -15,10 +15,10 @@ MemWatchTreeNode::MemWatchTreeNode(MemWatchEntry* const entry, MemWatchTreeNode*
 
 MemWatchTreeNode::~MemWatchTreeNode()
 {
-  if (hasChildren())
-    qDeleteAll(m_children);
+  deleteChildren();
   m_parent = nullptr;
   delete m_entry;
+  m_entry = nullptr;
 }
 
 bool MemWatchTreeNode::isGroup() const
@@ -117,6 +117,12 @@ void MemWatchTreeNode::removeChildren()
   m_children.clear();
 }
 
+void MemWatchTreeNode::deleteChildren()
+{
+  qDeleteAll(m_children);
+  m_children.clear();
+}
+
 void MemWatchTreeNode::readFromJson(const QJsonObject& json, MemWatchTreeNode* parent)
 {
   m_parent = parent;

diff --git a/Source/MemoryWatch/MemWatchTreeNode.h b/Source/MemoryWatch/MemWatchTreeNode.h
@@ -37,6 +37,7 @@ class MemWatchTreeNode
   void insertChild(int row, MemWatchTreeNode* node);
   void removeChild(int row);
   void removeChildren();
+  void deleteChildren();
 
   void readFromJson(const QJsonObject& json, MemWatchTreeNode* parent = nullptr);
   void writeToJson(QJsonObject& json) const;