Allow to add nexus user to additional groups #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremy-clerc
force-pushed
the
shared_group
branch
2 times, most recently
from
dd7af15
to
d719fe4
Compare
resources/default.rb
Outdated
| new_resource.nexus3_additional_groups.to_a.each do |gr| | ||
| group "add #{new_resource.nexus3_user} user to #{gr} group" do | ||
| group_name gr | ||
| action :manage |
There was a problem hiding this comment.
OPT: Use :modify instead to have Chef fail if the group does not exist
There was a problem hiding this comment.
I am not sure we want to fail, that's why I used manage in the first place, but yeah I am divided between it will show there is an issue and does it matter ?
And it is like I just want to "manage" members, not really modify the group more than that.
There was a problem hiding this comment.
Also I did not want any modification to the group attributes like gid, but yes the code is just about fail if it exists or not 😞
So updated to modify
jlundqvist-criteo
previously approved these changes
Feb 5, 2024
This will allow to provide a license file to be used by different instances or a single one without the need to manage it directly in the nexus cookbook.
jeremy-clerc
force-pushed
the
shared_group
branch
from
d719fe4
to
a8a0f2d
Compare
jlundqvist-criteo
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow to provide a license file to be used by different instances or a single one without the need to manage it directly in the nexus cookbook.