Add property to configure logback.xml #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
achamo
commented
Apr 4, 2024
achamo
commented
- Users are already able to configure logback for custom logging options outside of the cookbook. The main drawback is the restart of nexus required to take the changes into account.
- Here we allow them to pass their options directly to the resource with a template file and the cookbook name, to apply the template in the same resource and notify the restart at the same time.
* Users are already able to configure logback for custom logging options outside of the cookbook. The main drawback is the restart of nexus required to take the changes into account. * Here we allow them to pass their options directly to the resource with a template file and the cookbook name, to apply the template in the same resource and notify the restart at the same time. Change-Id: If22eb60d0797487625c2b2f28b37d0897867ca3e
* Because the resource is very long and splitting it wouldn't make a lot of sense Change-Id: Ida1197958d862a18d87d2ae21bdf66e00783d871
* Set an empty hash by default Change-Id: Iee83bd04cff62484a8a60d1038ce01f246a3c198
* To customize the template, we need variables Change-Id: Ifc3e96ad82f425f0f5e3f390814ce3ae5e73880a
Annih
approved these changes
Apr 5, 2024
Comment on lines
+112
to
+122
| template ::File.join(new_resource.data, 'etc', 'logback', 'logback.xml') do | ||
| source new_resource.logback_variables['source'] | ||
| cookbook new_resource.logback_variables['cookbook'] | ||
| mode '0644' | ||
| owner new_resource.nexus3_user | ||
| group new_resource.nexus3_group | ||
| variables(config: new_resource.logback_variables['config']) | ||
| notifies :restart, "nexus3_service[#{new_resource.service_name}]", :delayed | ||
| notifies :run, "ruby_block[#{blocker}]", :delayed | ||
| not_if { new_resource.logback_variables.empty? } | ||
| end |
There was a problem hiding this comment.
OPT/FAR: we could have a more generic solution allowing to inject any arbitrary template (not only logback).
With a bit of refacto I have the impression we could reuse the same system for nexus.vmoptions, nexus.properties & nexus.rc, and any future config need.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.