Skip to content

Commit

Permalink
Merge pull request #67 from criteo/generic-optional-monitoring
Browse files Browse the repository at this point in the history
hwbench: generic vendor: make monitoring file optional
  • Loading branch information
ErwanAliasr1 authored Feb 17, 2025
2 parents f2ec764 + 88b51b1 commit 51b8e4d
Showing 1 changed file with 13 additions and 2 deletions.
15 changes: 13 additions & 2 deletions hwbench/environment/vendors/generic.py
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
from .vendor import BMC, Vendor
from .mock import MockedBMC
from .vendor import Vendor


class GenericVendor(Vendor):
Expand All @@ -9,11 +10,16 @@ def __init__(
monitoring_config_filename,
):
super().__init__(out_dir, dmi, monitoring_config_filename)
self.bmc = BMC(self.out_dir, self)

def detect(self) -> bool:
return True

def prepare(self):
if self.get_monitoring_config_filename():
super().prepare()
else:
self.bmc = MockedBMC(self.out_dir, self)

def save_bios_config(self):
print("Warning: using Generic BIOS vendor")
# TODO: in the future, dump available BIOS config via redfish
Expand All @@ -28,3 +34,8 @@ def save_bmc_config(self):

def name(self) -> str:
return "GenericVendor"

def find_monitoring_sections(self, section_type: str, sections_list=[], max_sections=0):
if self.get_monitoring_config_filename():
return super().find_monitoring_sections(section_type, sections_list, max_sections)
return []

0 comments on commit 51b8e4d

Please sign in to comment.