Add some ruff checks #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is an issue with cairo, not related to my PR :( |
anisse
reviewed
Dec 20, 2024
anisse
reviewed
Dec 20, 2024
anisse
reviewed
Dec 20, 2024
|
You need to rebase to main so we can run the tests ;) |
|
Hello @Djailla in hwbench we test every commit, so appending a commit to fix tests won't work, you need to fix the faulty commits. |
Djailla
force-pushed
the
main
branch
2 times, most recently
from
f15490c to
8178e60
Compare
|
For the last commit, did you want to enable pyupgrade lints "UP" (I think the commit message is not what you intended). Also, since the ruff lints are now selected, we are losing the lints "E4", "E7" and "E9" from the ruff defaults: https://docs.astral.sh/ruff/configuration/ & https://github.com/astral-sh/ruff/blob/d45c1ee44f53d9c606085e79da1830b558fc001f/crates/ruff_workspace/src/options.rs#L739 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.