fix(new iot): angular package generation flag for MES >= 10.2.7 #467
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
--isAngularPackage
flag type was incorrectly marked as string, which was making it so that it was never recognized as true.Furthermore, there was a bug in the logic of version comparison (missing parentheses were causing, even with the
--isAngularPackage
flag set to true, on MES versions 10.2.7/8, the generation to happen for ATL packages instead of Angular ones. This part of the code was refactored to make it more readable.The test cases were updated to cover both the cases where the flag is explicitly passed or not, and for both versions prior and subsequent to 10.2.7. Additionally, a check was added to make sure angular package was indeed being generated (thought the presence of the file
angular.json
). All tests are passing now:Fixes #470.