Modify zksync-web3 to support custom gas token #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
why so many changes in abi? outdated? Otherwise lgtm. We can just prevent users to use the WETH bridge related functionalties |
Yes, those abi generated from the latest contracts we are using and I think they might not update it for a awhile. Maybe I can try to submit PR to the upstream repo and then revise this PR to make PR smaller? |
|
yeah its better to submit PR upstream on everything which is not related to our custom changes |
pushed an PR to the upstream |
thomas-nguy
reviewed
Nov 27, 2023
|
close this PR and redo it in #3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
migrating PR from cronos-labs/cronos-zkevm#26