Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem: eth_sender transaction's base fee is not capped #104

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jan 21, 2025

Cherry-picking #96 to v25.4.0

@JayT106 JayT106 self-assigned this Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

Hey there! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.
Examples of valid PR titles:

  • feat(eth_sender): Support new transaction type
  • fix(state_keeper): Correctly handle edge case
  • ci: Add new workflow for linting

Details:

Unknown release type "Problem" found in pull request title "Problem: eth_sender transaction's base fee is not capped". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@JayT106 JayT106 requested a review from thomas-nguy January 21, 2025 22:38
@JayT106 JayT106 force-pushed the jt/cp-v25.4.0-tx_fee_cap branch from 5fba753 to 2cab43e Compare January 23, 2025 15:39
@JayT106 JayT106 force-pushed the jt/cp-v25.4.0-tx_fee_cap branch from a8a6465 to 16365c2 Compare January 25, 2025 13:25
@thomas-nguy
Copy link
Member

I can still see this commit 2cab43e

@JayT106 JayT106 force-pushed the jt/cp-v25.4.0-tx_fee_cap branch 2 times, most recently from 280b6f0 to 7b18e43 Compare January 26, 2025 14:52
@JayT106 JayT106 force-pushed the jt/cp-v25.4.0-tx_fee_cap branch from 7b18e43 to 70d3631 Compare January 26, 2025 14:55
@JayT106
Copy link
Contributor Author

JayT106 commented Jan 26, 2025

I can still see this commit 2cab43e

removed

@thomas-nguy thomas-nguy merged commit 236a6e9 into cronos-v25.4.0 Jan 27, 2025
10 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants