Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update contract-verifier docker build file and add a document #41

Closed
wants to merge 2 commits into from

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Jan 16, 2024

What ❔

Update docker build for the cronos zkevm network deployment.

Copy link
Member

@thomas-nguy thomas-nguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

can you also make a PR upstream to fix their repo?

@JayT106
Copy link
Contributor Author

JayT106 commented Jan 19, 2024

lgtm

can you also make a PR upstream to fix their repo?

We failed the docker build looks like relate to our working laptop CA issue.
I use my personal mac laptop against zksync-core-v18.13.0, the docker file doesn't have build issue and all files are download correctly.

Maybe just leave it within our repo for saving our devops future efforts.

@JayT106 JayT106 closed this May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants