Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: missing GKMSSigner feature #78

Merged
merged 4 commits into from
Sep 6, 2024

Conversation

JayT106
Copy link
Contributor

@JayT106 JayT106 commented Sep 4, 2024

Cherry-picking PR #44 #50

@JayT106 JayT106 changed the base branch from testnet-v24.9.0 to cronos-v24.23.0 September 4, 2024 13:10
@JayT106 JayT106 self-assigned this Sep 4, 2024
@JayT106 JayT106 requested a review from thomas-nguy September 4, 2024 19:26
@thomas-nguy
Copy link
Member

the cargo.lock has a lot of changes, is it all related to the new package addition?

@JayT106
Copy link
Contributor Author

JayT106 commented Sep 5, 2024

the cargo.lock has a lot of changes, is it all related to the new package addition?

I guess I ran cargo update and build cause the issue. Updated the file.

@thomas-nguy thomas-nguy merged commit c79e5b7 into cronos-v24.23.0 Sep 6, 2024
9 of 50 checks passed
JayT106 added a commit that referenced this pull request Oct 24, 2024
JayT106 added a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants