Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): Update dependencies #1513

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

reneleonhardt
Copy link

Features

  • Update dependencies with cargo upgrade
  • Update GitHub Actions manually (others can be merged thanks to Dependabot #1464)
  • Configure Dependabot to update Rust, Python and Git too

Recommendations

  • Merge Dependabot updates or configure automerge
  • Release more often to fix security vulnerabilities for your users (unfixed in v0.2.5)
Library Vulnerability Severity
remove_dir_all GHSA-mc8h-8q98-g5hr LOW

Copy link
Member

@Emilgardis Emilgardis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the initiative! I like it, I just have some concerns about the frequency.

Also a note about CHANGELOG.md

CHANGELOG.md Outdated
Comment on lines 10 to 11
- Update dependencies

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not edit this changelog directly, instead see .changes

Comment on lines +51 to +66
- package-ecosystem: "cargo"
directory: "/"
schedule:
interval: "weekly"
groups:
rust_dependencies:
patterns:
- "*"
- package-ecosystem: "cargo"
directory: "/xtask"
schedule:
interval: "weekly"
groups:
rust_dependencies:
patterns:
- "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to only do a pr/update when a (cargo) semver break is done? e.g the first non-zero digit is changed. Reason is that I'm not sure we need to always be up to date, I can be persuaded about this though, I've just never seen the reason to keep track of the changes so closely.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe changing it to be done monthly?

Comment on lines +75 to +82
- package-ecosystem: "pip"
directory: "/docker/android"
schedule:
interval: "weekly"
groups:
python_dependencies:
patterns:
- "*"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto for this, I'd rather do this less often or only when a break happens.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants