Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward unstable feature flags (-Z) to cargo metadata invocations #1517

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rnza0u
Copy link

@rnza0u rnza0u commented Jun 24, 2024

The problem

I ran across some issues when using nightly Cargo features such as artifacts-dependencies.

Cargo forces users to pass a -Z bindeps flag to activate the feature in every cargo command.

Cross already forwards the +nightly flag to internal cargo invocations, but it does not forward -Z flags.

Consequently, cargo metadata always fail for projects using such feature.

This problem would also occur when using other Cargo nightly features.

Solution

Parse the -Z flags and forward them to cargo metadata.

@rnza0u rnza0u requested a review from a team as a code owner June 24, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant