chore: Update README.md #189
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update install provider manifest to use 0.8.0 instead of 0.2.0 since the examples contain resources that didn't exist in 0.2.0
MisterMX
approved these changes
Aug 20, 2024
There was a problem hiding this comment.
@mirzakopic thanks for the change. LGTM. Can you signoff your commit so we can merge it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the readme, update the install provider manifest to use version 0.8.0 instead of 0.2.0 since the examples directory contains resources that have been updated since 0.2.0 (e.g. Cluster has a
spec.forProvider.config.kubeconfigSecretRefas of version 0.4.0)I have:
make reviewable testto ensure this PR is ready for review.How has this code been tested
No tests as there is only markdown change.